Skip to content

Added CSS build check by Actions #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsbt wants to merge 3 commits into
base: master
Choose a base branch
from
+1,529 −3
Open

Added CSS build check by Actions #3713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
891710e
Add CSS build check to CI
taea Dec 18, 2025
7be27e0
Exclude to check node_modules at `rake test`
hsbt Dec 22, 2025
e672ba1
Update package.json from renewal project
hsbt Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,14 @@ jobs:
run: ruby -v
- name: Run tests
run: bundle exec rake test
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'npm'
- name: Install npm dependencies
run: npm ci
- name: Check CSS is up-to-date
run: |
npm run build-css
git diff --exit-code stylesheets/compiled.css || (echo "Error: compiled.css is out of date. Run 'npm run build-css' and commit the changes." && exit 1)
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message could be improved for clarity. Currently it says "Error: compiled.css is out of date" but it would be more helpful to specify which file needs to be regenerated and how to do it locally. Consider making the message more actionable, for example: "The compiled CSS is out of date. Please run 'npm run build-css' locally and commit the updated stylesheets/compiled.css file."

Suggested change
git diff --exit-code stylesheets/compiled.css || (echo "Error: compiled.css is out of date. Run 'npm run build-css' and commit the changes." && exit 1)
git diff --exit-code stylesheets/compiled.css || (echo "Error: The compiled CSS is out of date. Please run 'npm run build-css' locally and commit the updated stylesheets/compiled.css file." && exit 1)

Copilot uses AI. Check for mistakes.
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ vendor
bin
.jekyll*
node_modules/
package-lock.json
_figma/
_svg-backup/
Loading
Loading