Destination in server.rb logout now set and used correctly.

[dyson]

The destination URL does not makes sense to be a substitute to service URL if the service URL is not set. This commit fixes that behaviour.

[dyson]

Apologies the final block of ifs should needed an update to allow either forwarding to the service if it's a gateway (cas standard) or forward to the destination url if set (non cas standard but you already had implemented).

Also there is no logout template so if there is a continue_url passed you get an error. I set it to use the login template.

[zuk]

Potential changes to behaviour... needs closer evaluation before merging.

[luckyruby]

Any updates?

[mitfik]

I work on that to clear this commit and prepare test for it.
Because in that form we can't merge it.

Thanks a lot for contribution.
Soon I will back to you.

[mitfik]

I investigate that a little bit more and I honestly I do not see any reason why someone would like to use it.
Could you provide some scenario for default_service option?

[dyson]

This was just here because if someone goes straight to the rubycas server they just get a page saying they are logged in. I actually wanted them to go to something more useful like our main service. Also if they were already logged in and went straight to the rubycas server the same thing happens.

So if you had https://sso.example.com someone can go directly to that page and they get stuck.

Mos tof the time you want users to log in via a service such as https://service.example.com but they might not. This way you can default where they should go if they go straight to https://sso.example.com

I think as you point out below this was because continue_url was not coded correctly, and I can't remember what the specs say on that.

I've rolled my own solution since my initial playing around with rubycas-server so might be best to close this and submit a new cleaner patch. This patch was just a stepping stone that got it working for me how I needed it to work.