proposals.proposal_data may include serialized AC::Parameters as well #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because CFP App 1.0 used to store proposals.proposal_data as a serialized AC::Parameters. This follows up d70de79 and fixes `Psych::DisallowedClass: Tried to load unspecified class: ActionController::Parameters`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because CFP App 1.0 used to store proposals.proposal_data as a serialized AC::Parameters.
This follows up d70de79 and fixes
Psych::DisallowedClass: Tried to load unspecified class: ActionController::Parameterserror that occurs when trying to show proposals that are posted on CFP App Version 1.I know that Ruby Central folks may have never seen this error since you gave up migrating the V1 data to V2 and just abandoned them, but for those who somehow migrated the old data to V2 like we did for our conference RubyKaigi, I chose to upstream this patch instead of just updating our
proposal_datain our DB to be normal Hash objects.