Fix uniqueness validator for non-paranoid models.#256
Open
mlabarca wants to merge 1 commit intorubysherpas:rails3from
Open
Fix uniqueness validator for non-paranoid models.#256mlabarca wants to merge 1 commit intorubysherpas:rails3from
mlabarca wants to merge 1 commit intorubysherpas:rails3from
Conversation
tddrmllr
pushed a commit
to tddrmllr/paranoia
that referenced
this pull request
Nov 25, 2015
|
👍 for fixing this for the rails3 branch. It could also be done guard clause style since that's how it is the rails4 branch currently: https://github.com/rubysherpas/paranoia/blob/rails4/lib/paranoia.rb#L265 |
|
After some more thought, I'm in favor of reverting the uniqueness validator as in #277 |
|
Many thanks for this patch. I had to fork the repo in order to use because it looks like it won't be merged. But that's ok for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I mentioned on #250, simply attempting to create a non paranoid model with an uniqueness validation fails since it attempts to filter out records with paranoid column != nil from the relation. This is the very same fix in 3b6ff6e but for this rails3 branch which is what I'm depending on.