Call add_to_transaction on #restore! as well#297
Open
Empact wants to merge 1 commit intorubysherpas:rails4from
Open
Call add_to_transaction on #restore! as well#297Empact wants to merge 1 commit intorubysherpas:rails4from
add_to_transaction on #restore! as well#297Empact wants to merge 1 commit intorubysherpas:rails4from
Conversation
Under certain conditions, combining the use of paranoia and counter_culture can result in callbacks not being run. This is perhaps due to an interaction between after_commit_action and user-defined after_commit callbacks, but unfortunately I have been unable to pin this down in tests. Note this makes restore! roughly symmetric with delete/destroy in its existing use of add_to_transaction.
Contributor
Author
|
I made some fairly extensive efforts to repro under test then gave up. What do you guys think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain conditions, combining the use of paranoia and
counter_culture can result in callbacks not being run. This is
perhaps due to an interaction between after_commit_action and
user-defined after_commit callbacks, but unfortunately I have been
unable to pin this down in tests.
Note this makes restore! roughly symmetric with delete/destroy in
its existing use of add_to_transaction.