Add paranoia_destroy_attributes support for really_destory!#344
Open
shizm wants to merge 1 commit intorubysherpas:corefrom
Open
Add paranoia_destroy_attributes support for really_destory!#344shizm wants to merge 1 commit intorubysherpas:corefrom
shizm wants to merge 1 commit intorubysherpas:corefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If target model has paranoia_destroy_attributes method and called really_destroy method,
attribute is not updated correctly, so deprecation warning message has shown.
DEPRECATION WARNING: You attempted to assign a value which is not explicitlytrueorfalse(2016-07-13 08:38:45 UTC) to a boolean column. Currently this value casts tofalse. This will change to match Ruby's semantics, and will cast totruein Rails 5. If you would like to maintain the current behavior, you should explicitly handle the values you would like cast tofalse. (called from block in <main> at (pry):2)