Feature/dirty tracking#416
Open
dgmora wants to merge 3 commits intorubysherpas:corefrom
dgmora:feature/dirty-tracking
Open
Feature/dirty tracking#416dgmora wants to merge 3 commits intorubysherpas:corefrom dgmora:feature/dirty-tracking
dgmora wants to merge 3 commits intorubysherpas:corefrom
dgmora:feature/dirty-tracking
Conversation
Collaborator
|
can you rebase or merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took what the first commit from #375
As far as I understood,
update_columnsdoes not track changes withDirtybecause it does not use the regular attribute setters, it usesraw_write_attribute.raw_write_attributealso clears the changes in 5.1.x. See here (which is called fromupdate_columns.superis in persistence).Adding
deleted_at_will_change!andchanges_appliedworks except for rails 5.0.x, couldn't find the reason. It looks like the AttributeMutationTracker does not track the change indeleted_atcorrectly