.really_destroy! should not destroy has_many :through records#467
Open
atd wants to merge 1 commit intorubysherpas:corefrom
Open
.really_destroy! should not destroy has_many :through records#467atd wants to merge 1 commit intorubysherpas:corefrom
atd wants to merge 1 commit intorubysherpas:corefrom
Conversation
mathieujobin
requested changes
Mar 23, 2022
Collaborator
mathieujobin
left a comment
There was a problem hiding this comment.
I see that current tests pass https://github.com/rubysherpas/paranoia/actions/runs/2026327334
But I would like to see a test case added for this and few more people advocating for this to be merged before taking side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite of counter intuitive, Rails API states that
has_many :throughrecords must not be destroyed, but their associations https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_manyparanoiashould have the same behaviorFixes #466