logical plan distributed optimizer #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Jul 25, 2025
|
|
||
| remoteNodes := make([]logicalplan.RemoteExecution, 1) | ||
|
|
||
| remoteNodes[0] = logicalplan.RemoteExecution{ |
There was a problem hiding this comment.
I don't think it makes sense to reuse RemoteExecution from thanos engine's distributed optimizer. We should define our own.
The exising remote node is for thanos engine to work as it has query and start end information. For us to work we need to define our own logicalplan node type and pass down the information we need like fragment ID and query ID, etc
yeya24
reviewed
Jul 26, 2025
| return &optimizedPlan, nil | ||
| dOptimizer := DistributedOptimizer{} | ||
| dOptimizedPlanNode, _ := dOptimizer.Optimize(optimizedPlan.Root(), &qOpts) | ||
| lp := logicalplan.New(dOptimizedPlanNode, &qOpts, planOpts) |
There was a problem hiding this comment.
This step is unnecessary. We should just return dOptimizedPlanNode
| @@ -67,7 +67,11 @@ func (d distributedQueryMiddleware) newLogicalPlan(qs string, start time.Time, e | |||
| logicalPlan := logicalplan.NewFromAST(expr, &qOpts, planOpts) | |||
| optimizedPlan, _ := logicalPlan.Optimize(logicalplan.DefaultOptimizers) | |||
There was a problem hiding this comment.
You can append distributed optimizer here and optimize the plan in one pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Distributed optimizer with a predefined pattern
and expected output for queries like sum(A) + sum(B)
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]