Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server, webui]: Add hostname value, optional support for external-dns #244

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

lobis
Copy link
Contributor

@lobis lobis commented Mar 3, 2025

Closes #248

We have been trying external-dns to manage the dns records for our services with good results.

external-dns uses annotations in the services in order to work.

Getting the correct configuration with the current rucio charts was not straightforward and it required having duplicated config values (you don't want to hardcode the hostname in multiple places). This can be fixed by adding a configuration value named hostname which then can be referenced elsewhere.

The way to enable external-dns is via a disabled-by-default flag named useExternalDNS which adds the necessary annotations. While the current design which allows arbitrary annotations works in theory, it requires duplication of values.

I refactored the section related to the service annotations since now we have more than one source of annotations.

@lobis lobis requested review from bari12 and rdimaio March 3, 2025 11:32
@bari12 bari12 merged commit 7a08297 into rucio:master Mar 4, 2025
1 check passed
@lobis lobis deleted the hostname-value-external-dns branch March 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hostname value to avoid duplication
2 participants