Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server, webui, daemons]: Support setting tls secrets by name #245

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

lobis
Copy link
Contributor

@lobis lobis commented Mar 3, 2025

Closes #246

Add new field tlsSecretName (unset by default) which can be used to point to a tls secret which will then be used to setup the public/private keys for tls.

I think this provides a cleaner approach compared to asking the user to mount some secrets into some specific paths.

Before this change you would need to do:

  secretMounts:
    - secretFullName: rucio-tls-host-cert
      mountPath: /etc/grid-security/hostcert.pem
      subPath: tls.crt
    - secretFullName: rucio-tls-host-key
      mountPath: /etc/grid-security/hostkey.pem
      subPath: tls.key

After this can optionally be condensed into:

tlsSecretName: rucio-tls-host

Besides the reduced lines of code needed, now (IMHO) it's easier for a new user to figure out how to setup tls from looking at the helm chart.

This change just adds an alternative way to configure tls, the old way still works fine.

@lobis lobis requested review from rdimaio and bari12 March 3, 2025 13:46
@bari12 bari12 merged commit 2710ac9 into rucio:master Mar 4, 2025
1 check passed
@lobis lobis deleted the tls-secret branch March 4, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of TLS secrets by secret name instead of explicit mounts
2 participants