[server, webui, daemons]: Support setting tls secrets by name #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
Add new field
tlsSecretName
(unset by default) which can be used to point to a tls secret which will then be used to setup the public/private keys for tls.I think this provides a cleaner approach compared to asking the user to mount some secrets into some specific paths.
Before this change you would need to do:
After this can optionally be condensed into:
Besides the reduced lines of code needed, now (IMHO) it's easier for a new user to figure out how to setup tls from looking at the helm chart.
This change just adds an alternative way to configure tls, the old way still works fine.