Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional deployment annotations #251

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

lobis
Copy link
Contributor

@lobis lobis commented Mar 14, 2025

Closes #250

Via annotations one can configure reloader to reload the related service whenever a change to a secret or configmap happens:

  deploymentAnnotations:
    reloader.stakater.com/auto: "true"

By default deployments will be reloaded whenever any secret/map mounted on them is changed. This can be configured with great granularity via annotations either in the deployment or secrets (you only want to reload whenever one particular secret changes, etc.). I think the default behaviour is good enough.

Via this strategy the server will reload whenever the policy package is updated, or daemons will reload whenever the certificate is updated by the cronjob.

@lobis lobis added the enhancement New feature or request label Mar 14, 2025
@lobis lobis requested review from dchristidis and rdimaio March 14, 2025 08:26
@lobis lobis force-pushed the 250-deployment-annotations branch from f0ed0d5 to b3cb9fb Compare March 14, 2025 08:28
Copy link
Contributor

@rdimaio rdimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would be useful if the deploymentAnnotations: {} in the values files also had an example of how some sample annotations would need to be added in order for this to work (e.g. if i want to add 2 annotations, do i need to prefix them with a dash?)

@lobis
Copy link
Contributor Author

lobis commented Mar 14, 2025

LGTM - would be useful if the deploymentAnnotations: {} in the values files also had an example of how some sample annotations would need to be added in order for this to work (e.g. if i want to add 2 annotations, do i need to prefix them with a dash?)

I added some comments showcasing usage.

@rdimaio rdimaio merged commit 13cb78c into rucio:master Mar 14, 2025
1 check passed
@lobis lobis deleted the 250-deployment-annotations branch March 14, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally use reloader for restarting services when secrets change
2 participants