refactor(codegen): use interned symbol_id for call instructions #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
force-pushed
the
steveklabnik/push-uuwluvmqwmwz
branch
from
f9d2299 to
e1b90c2
Compare
Replace heap-allocated String with u32 symbol index in CallRel (x86_64) and Bl (aarch64) instructions. This reduces enum size from 24 bytes to 4 bytes per call instruction and eliminates allocations during MIR construction. Changes: - Add symbol table (Vec<String>) to X86Mir and Aarch64Mir - Add intern_symbol/get_symbol methods for symbol management - Update cfg_lower.rs to intern symbols when emitting calls - Update emit.rs to resolve symbols from table at emit time - Update regalloc.rs to transfer symbol table during rewriting Closes rue-frgb 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
steveklabnik
force-pushed
the
steveklabnik/push-uuwluvmqwmwz
branch
from
e1b90c2 to
46d517e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace heap-allocated String with u32 symbol index in CallRel (x86_64) and Bl (aarch64) instructions. This reduces enum size from 24 bytes to 4 bytes per call instruction and eliminates allocations during MIR construction.
Changes:
Closes rue-frgb
🤖 Generated with Claude Code