-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove actionbar in PlayerActivity and add exit button to menu #88
Conversation
true | ||
if (item.itemId == resourceIdExit) { | ||
finish() | ||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the true
can be kept out of the branch, as it's the same in both arms.
@@ -123,9 +123,16 @@ class PlayerActivity : GameActivity() { | |||
item.setChecked(true) | |||
} | |||
} | |||
val resourceIdExit: Int = items.size + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this has anything to do with resources...? 🤔
As in, these things:
https://developer.android.com/guide/topics/resources/providing-resources
https://developer.android.com/reference/android/content/res/Resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what to call it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps item?
I can fix up these minor nits, and rebase/squash your commits before merging, if you don't mind. |
@torokati44 Yes, please make any changes you think are good! |
Turns out, your |
BTW in the future, it would be better to make a dedicated branch for PRs, so this is avoided. :) |
Okay, just to be precise, I was able to force-push to it, once. I intended to push my local |
...now in Kotlin ;) (previously #66)