Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more recursive failures #68

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

CUB3D
Copy link
Collaborator

@CUB3D CUB3D commented Sep 16, 2024

This applies the same changes as in #67 to all other Value types that can have non-trivial children leading to reference cycles.

Also adds a fuzzer for the parse_single_element function. With this changeset neither fuzz_amf0_body fuzz_amf3_body or fuzz_amf3_single_element panic after ~500million fuzz cases each.

Note this is not as clean as I would like, but I want to fix the panics first and worry about the refactor later

@torokati44
Copy link
Member

Thank you for addressing my nitpicks!
As this is still mostly your project, I trust that you know what you're doing; and quickly glancing through the changes, I don't see anything immediately problematic.
While I would've kept the commit history neater, it's not a big deal (and this repo already has many "cosmetic" commits) - so in the name of progress, I say let's just get this in.

@torokati44 torokati44 merged commit cbd18e1 into master Sep 30, 2024
1 check passed
@torokati44 torokati44 deleted the fix_more_recursive_failures branch September 30, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants