Conversation
Author
|
If anything's wrong I hope you'll forgive me lol, this is my first PR to another OS repo so I'm still sort of learning as I go haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Before submitting a pull request, you must attest to the following:
Summary
Previously, Spotify local files could end up in queues, including shuffle queues, which would cause the metadata resolver to simply "guess" the song, which would generally be incorrect. This solves this issue.
Linked Work
Change Type
Affected Surfaces
:app:core:lyrics:lastfm:canvas:shazamkit:spotifycoreScreenshots / Recordings
Behavior Notes
parseGqlTracknow setsSpotifyTrack.isLocal, meaning that they're excluded from both the playlist listing and queues when playing a playlist. Local files in a Spotify playlist should no longer show in the track list nor should they appear in the queue when the playlist is played.Architecture Checklist
runBlockingis introduced in app execution paths.All others N/A
Compose / Material Checklist
N/A
Concurrency / Performance Checklist
All others N/A
Data / Persistence Checklist
N/A
Playback / Integration Checklist
N/A
Localization / Assets Checklist
N/A
Privacy / Security Checklist
Verification
Reviewer Focus
Spotify GQL parsing (
parseGQLTrack), verify that local files are excluded from Spotify tracklists and queues and confirm that normal tracks work fine.Release Notes
Excluded Spotify local files from Spotify playlists.