[wip] fix instrumentation and workflow tracebacks #17749
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix how tracebacks are handled in instrumentation and in workflows.
This isn't quite correct though, it breaks unit tests. I think I'm hiding some exceptions, causing some cleanup/handling not to run in the workflow?
Attempts to fix #17728
Attempts to fix #17730
Here's the extra test code I was using (which does actually run cleanly)