Contextual Generate model #17913
Open
Contextual Generate model #17913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-smith
force-pushed
the
contextual-clm
branch
3 times, most recently
from
0c332c3 to
2b2f3dc
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sean-smith
force-pushed
the
contextual-clm
branch
from
2b2f3dc to
6239fdd
Compare
dosubot
bot
added
the
size:L
llama-index-integrations/llms/llama-index-llms-contextual/tests/test.py
Outdated
Show resolved
Hide resolved
llama-index-integrations/llms/llama-index-llms-contextual/llama_index/llms/contextual/base.py
Outdated
Show resolved
Hide resolved
sean-smith
force-pushed
the
contextual-clm
branch
3 times, most recently
from
26236cd to
89318d5
Compare
|
@logan-markewich can you approve the workflows? |
sean-smith
force-pushed
the
contextual-clm
branch
from
89318d5 to
403d39a
Compare
|
Pinging on this @logan-markewich |
Signed-off-by: Sean Smith <[email protected]>
sean-smith
force-pushed
the
contextual-clm
branch
from
bd2e611 to
afcaf34
Compare
| """ | ||
| raise NotImplementedError("stream methods not implemented in Contextual") | ||
|
|
||
| def _generate( |
There was a problem hiding this comment.
This seems fairly open ai compatible -- any reason not not just use the base openai client and change the model args?
Also what you have here doesn't override any async methods, so those will still call the normal openai client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods