Aquery ivfflat fix #17922
Open
Aquery ivfflat fix #17922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the issue, vector store index querying was not successful when the PGVectorStore was initialized with the `ivfflat_probes` argument. This problem is potentially due to the behavior of psycopg3 sending parameters separately, using [server-side binding](https://www.psycopg.org/psycopg3/docs/basic/from_pg2.html#server-side-binding), which may mis-behave when performed asynchronously. However, this is just a hypothesis and may be related to a different issue. The proposed solution works successfully and formats the variable directly in the `SET` string.
Adding pytest per conributing guidelines
…to aquery_ivfflat_fix
dosubot
bot
added
the
size:M
|
NOTE: This integration should be updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the issue, vector store index querying was not successful
when the PGVectorStore was initialized with the
ivfflat_probesargument.This problem is potentially due to the behavior of psycopg2/3 relying on server-side binding,
which does not support SET statements. However, this is just
a hypothesis and may be related to a different issue.
The proposed solution works successfully and formats the variable directly
in the
SETstring.Fixes # 17877
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods