-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added a reader using the multimodal capability of Gemini #18020
Open
sumitaryal
wants to merge
12
commits into
run-llama:main
Choose a base branch
from
sumitaryal:feature/gemini-pdf-reader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
all_documents = [] | ||
|
||
with ThreadPoolExecutor(max_workers=self.max_workers) as executor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo, it is 100000x times safer to be using async concurrency vs. threading. I would prefer something like asyncio.gather()
behind a semaphore -- we actually have utility for this as well
from llama_index.core.async_utils import run_jobs
jobs = [some_async_fn() for x in thing]
results = await run_jobs(jobs, workers=self.max_workers)
llama-index-integrations/readers/llama-index-readers-gemini/llama_index/readers/gemini/base.py
Show resolved
Hide resolved
llama-index-integrations/readers/llama-index-readers-gemini/llama_index/readers/gemini/base.py
Outdated
Show resolved
Hide resolved
llama-index-integrations/readers/llama-index-readers-gemini/pyproject.toml
Outdated
Show resolved
Hide resolved
llama-index-integrations/readers/llama-index-readers-gemini/tests/test_readers_gemini.py
Outdated
Show resolved
Hide resolved
…ryal/llama_index into feature/gemini-pdf-reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add GeminiReader: AI-powered PDF extraction using Google's Gemini models
This PR introduces a new LlamaIndex reader integration that leverages Google's Gemini AI models for high-quality PDF extraction and intelligent chunking.
Motivation
Traditional PDF parsers often struggle with complex layouts, scanned documents, tables, and forms. By utilizing Gemini's vision capabilities, this reader provides significantly better extraction quality and semantic chunking for improved RAG performance.
Key Features
Implementation
The reader is built as a BasePydanticReader extension with comprehensive configuration options. It creates semantically meaningful document chunks while preserving metadata about their source and position in the original document.
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods