feat(mongo reader): field_extractors #18063
Open
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
| @@ -40,12 +41,6 @@ def __init__( | |||
|
|
|||
| self.client = client | |||
|
|
|||
| def _flatten(self, texts: List[Union[str, List[str]]]) -> List[str]: | |||
There was a problem hiding this comment.
Why do we remove flatten?
There was a problem hiding this comment.
texts is already of type list[str], so calling _flatten(texts) simply returns texts itself without any modifications. Therefore, removing _flatten simplifies the code without changing its behavior.
| for item in cursor: | ||
| try: | ||
| texts = [str(item[name]) for name in field_names] | ||
| texts = [ | ||
| field_extractors.get(name, str)(item[name]) for name in field_names |
There was a problem hiding this comment.
.get(name, str) does not work? What does this return when name isn't in the dict?
There was a problem hiding this comment.
It is dict.get, so it will return the str type (acting the same as the original) if name isn't in the dict.
david20571015
force-pushed
the
mongo-reader
branch
from
391928e to
e02b503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
field_extractorsto allow users to customize how data is extracted from MongoDB.New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods