Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting externalTrafficPolicy on service #411

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Allow setting externalTrafficPolicy on service #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9374062
Allow setting externalTrafficPolicy on service
aleksy-zalenski Aug 2, 2024
adeb078
Bump the chart version to 5.4.4
aleksy-zalenski Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/atlantis/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
appVersion: v0.28.5
description: A Helm chart for Atlantis https://www.runatlantis.io
name: atlantis
version: 5.4.3
version: 5.4.4
keywords:
- terraform
home: https://www.runatlantis.io
Expand Down
1 change: 1 addition & 0 deletions charts/atlantis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ extraManifests:
| repoConfig | string | `""` | Use Server Side Repo Config, ref: https://www.runatlantis.io/docs/server-side-repo-config.html. Check values.yaml for examples. |
| resources | object | `{}` | Resources for Atlantis. Check values.yaml for examples. |
| service.annotations | object | `{}` | |
| service.externalTrafficPolicy | string | `nil` | |
| service.loadBalancerIP | string | `nil` | |
| service.loadBalancerSourceRanges | list | `[]` | |
| service.nodePort | string | `nil` | |
Expand Down
3 changes: 3 additions & 0 deletions charts/atlantis/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ spec:
{{- if .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{- end }}
{{- if .Values.service.externalTrafficPolicy }}
externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
{{- end }}
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
Expand Down
8 changes: 8 additions & 0 deletions charts/atlantis/tests/service_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ tests:
app: atlantis
release: my-release
type: NodePort
- it: externalTrafficPolicy
set:
service:
externalTrafficPolicy: Local
asserts:
- equal:
path: spec.externalTrafficPolicy
value: Local
- it: loadBalancerSourceRanges
set:
service:
Expand Down
7 changes: 7 additions & 0 deletions charts/atlantis/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,13 @@
],
"default": 4141
},
"externalTrafficPolicy": {
"description": "externalTrafficPolicy to set on service.",
"type": [
"string",
"null"
]
},
"loadBalancerIP": {
"description": "IP address to assign to load balancer (if supported).",
"type": [
Expand Down
1 change: 1 addition & 0 deletions charts/atlantis/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ service:
targetPort: 4141
loadBalancerIP: null
loadBalancerSourceRanges: []
externalTrafficPolicy: null

podTemplate:
# -- Check values.yaml for examples.
Expand Down