Fix flankAuth task compatibility with Gradle configuration cache (#381) #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #381 reported that the flankAuth task was not compatible with Gradle's configuration cache, causing serialization errors when the configuration cache was enabled.
Root Cause
The issue was caused by two main problems:
project.layout.buildDirectory
which requires serializing the entire Project object, violating configuration cache requirementsSolution
Changes Made
FlankJavaExec.kt (line 20)
project.layout.buildDirectory
toprojectLayout.buildDirectory.dir("fladle/$configName")
FladlePluginDelegate.kt (lines 25-33)
ConfigurationCacheTest.kt (lines 108, 113)
Testing
Verification
The fix has been thoroughly tested:
Fixes #381