Enable thunking #applyUnOp
#595
Merged
+2,385
−418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
commented
May 21, 2025
Comment on lines
+79
to
+89
| ┃ ├─ 12 | ||
| ┃ │ #selectBlock ( switchTargets ( ... branches: .Branches , otherwise: basicBlockId | ||
| ┃ │ | ||
| ┃ │ (85 steps) | ||
| ┃ └─ 17 (vacuous, leaf) | ||
| ┃ #expect ( typedValue ( BoolVal ( 0 <Int size ( ARG_ARRAY7:List ) ) , ty ( 28 ) , | ||
| ┃ | ||
| ┗━━┓ | ||
| │ | ||
| └─ 13 (stuck, leaf) | ||
| #selectBlock ( switchTargets ( ... branches: branch ( 0 , basicBlockIdx ( 7 ) ) |
There was a problem hiding this comment.
We can see we're getting vacuous and stuck nodes (which are nonsensical), and that our #switchBlocks is not carrying through side-conditions correctly. That will have to be investigated in a further PR.
dkcumming
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of programs were getting stuck at
#applyUnOpfor unimplemented operations, this enables thunking unary operations. In particular:#applyUnOpis put in sortEvaluationso that thunking can happen.#computeis renamed to#applyBinOp.#compute => #applyBinOphas an effect, and 2 where we get further into execution of programs because we thunk up#applyUnOp(including the P-token test).