Add simplifications for bytes converted to u64 #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anches in p-token)
jberthold
requested review from
Stevengre and
dkcumming
and removed request for
dkcumming
dkcumming
approved these changes
Nov 12, 2025
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
I believe these make sense!
Merged
jberthold
added a commit
that referenced
this pull request
Nov 12, 2025
* Add simplifications for bytes converted to u64 (#837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes artefacts of round-trip conversion between bytes and u64 (starting with bytes).
This enables recognising the magnitude limit of
2^64of the converted bytes (eliminates vacuous branches in p-token).