fix(runtime): tolerate Windows receipt fsync limits#219
Open
liomilet4-png wants to merge 1 commit into
Open
Conversation
Author
|
Thanks for taking a look. The PR workflows currently appear to be waiting for maintainer approval ( Could a maintainer approve the workflows so the branch can run CI? The change is intentionally limited to the Windows receipt-store fsync/directory-sync behavior, with local validation passing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a remaining Windows receipt-store durability failure on the current
mainbranch.sync_allraw OS error 87 after the receipt file has been written and flushedFile::open(path)?.sync_all()behavior unchangedThis is intentionally a focused one-file PR. Existing broader receipt/skill PRs such as #201 are conflict-heavy and do not cover the temp-file
sync_allerror path on currentmain.Validation
cargo fmt -p runx-runtime -- --checkgit diff --check -- crates/runx-runtime/src/receipts/store.rscargo test -p runx-runtime receipt_store -- --nocapturereceipt_store26 passed, 0 failedScope
The change is limited to local receipt-store durability sync behavior. It does not change receipt IDs, receipt file naming, signatures, verification policy, harness authority, or any public schema.