Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of allocations needed to find a specific child/sibling #119

Closed
wants to merge 13 commits into from
Closed

Reduce the number of allocations needed to find a specific child/sibling #119

wants to merge 13 commits into from

Commits on Oct 3, 2021

  1. Attempt to reduce the allocations needed to iterate through the child… 

    …ren of SyntaxNode/SyntaxElement
    @theo-lw
    theo-lw committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    3d93945 View commit details
    Browse the repository at this point in the history

  2. Reduce allocations when looking through children with tokens, remove … 

    …the generic parameter over Fn(SyntaxKind) from the outwards facing api
    @theo-lw
    theo-lw committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    fd63d90 View commit details
    Browse the repository at this point in the history

  3. Run cargo fmt

    @theo-lw
    theo-lw committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    05e47e9 View commit details
    Browse the repository at this point in the history

  4. Moved 'a to children_with_tokens_matching

    @theo-lw
    theo-lw committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    9b96915 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. Expose the api as children().by_kind

    @theo-lw
    theo-lw committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    5d62e45 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary functions, fix off-by-one error

    Theodore Luo Wang committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    0dad088 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Lazily create SyntaxNodeChildren::next and SyntaxElementChildren::nex… 

    …t (i.e, only if we start iterating through them) to avoid some unnecessary allocations when calling by_kind
    Theodore Luo Wang committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    94b039c View commit details
    Browse the repository at this point in the history

  2. Run cargo fmt

    Theodore Luo Wang committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    bff5da8 View commit details
    Browse the repository at this point in the history

  3. Change Syntax*ChildrenMatching -> Syntax*ChildrenByKind

    Theodore Luo Wang committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    8ba46a7 View commit details
    Browse the repository at this point in the history

  4. Run cargo fmt

    Theodore Luo Wang committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    2b94548 View commit details
    Browse the repository at this point in the history

  5. Change function names to use by_kind instead of matching. Use &dyn Fn… 

    … instead of generic impl Fn.
    Theodore Luo Wang committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    3f283c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Expose SyntaxNodeChildrenByKind

    Theodore Luo Wang committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    04e1a2a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Changes per Veykril's comments

    Theodore Luo Wang committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    39b5410 View commit details
    Browse the repository at this point in the history