Fix on-chain amount rounding#24
Open
benthecarman wants to merge 2 commits into
Open
Conversation
The configurable amount path rounded millisats up to whole sats but then constructed the result as millisats. Fix the bug by building the rounded value as sats so on-chain fixed-amount instructions has the correct amount. Added a test to find regressions.
benthecarman
force-pushed
the
fix-onchain-amount-rounding
branch
12 times, most recently
from
f4c6e40 to
012322f
Compare
benthecarman
force-pushed
the
fix-onchain-amount-rounding
branch
from
012322f to
2b2fb70
Compare
Member
|
Can you update the pins for |
Later releases of libc, unicode-ident, honggfuzz, and semver raise their MSRV above this crate's 1.63 MSRV, breaking the MSRV CI job. Pin them to the last compatible versions, matching the existing syn/quote/proc-macro2 pins. honggfuzz is also pinned at install time in ci-fuzz.sh since the version is selected by `cargo install`.
benthecarman
force-pushed
the
fix-onchain-amount-rounding
branch
from
827888d to
f0c2d4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configurable amount path rounded millisats up to whole sats but then constructed the result as millisats. Fix the bug by building the rounded value as sats so on-chain fixed-amount instructions has the correct amount. Added a test to find regressions.