Remove GenerateBlockError in v21-24#300
Merged
Merged
Conversation
Merged
jamillambert
force-pushed
the
0616-remove-error
branch
2 times, most recently
from
bf6d7e8 to
acec673
Compare
This only has one field and the error can be returned directly. From v25 onwards there are 2 distinct types and the error enum has been left.
jamillambert
force-pushed
the
0616-remove-error
branch
from
acec673 to
925b5be
Compare
tcharding
approved these changes
Jul 19, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
925b5becee9451e1c80a501972839bdfe0e0afa9 Remove GenerateBlockError in v21-24 (Jamil Lambert, PhD)
Pull request description:
This only has one field and the error can be returned directly.
From v25 onwards there are 2 distinct types and the error enum has been left.
ACKs for top commit:
tcharding:
ACK 925b5becee9451e1c80a501972839bdfe0e0afa9
Tree-SHA512: ac01c730ef6f3d8f5be89370834e85b3c234c98d2ce10815cec8ebb0d2b975ee7f42522af877cbe9ba516c4b465e052f4e15ac019b7c27bcaef3c36591e77b6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only has one field and the error can be returned directly.
From v25 onwards there are 2 distinct types and the error enum has been left.