Add full stops to rustdocs in client#302
Merged
tcharding merged 1 commit intoJul 22, 2025
Merged
Conversation
jamillambert
force-pushed
the
0718-client-fullstops
branch
from
ac27d49 to
30492e9
Compare
tcharding
reviewed
Jul 19, 2025
Comment on lines
+20
to
+25
| false.into(), // disable_private_keys | ||
| false.into(), // blank | ||
| serde_json::Value::Null, // passphrase | ||
| false.into(), // avoid_reuse | ||
| true.into(), // descriptors=true | ||
| serde_json::Value::Null, // load_on_startup | ||
| false.into(), // disable_private_keys. | ||
| false.into(), // blank. | ||
| serde_json::Value::Null, // passphrase. | ||
| false.into(), // avoid_reuse. | ||
| true.into(), // descriptors=true. | ||
| serde_json::Value::Null, // load_on_startup. |
Member
There was a problem hiding this comment.
These are incorrect. We only want to do rustdocs, in code comments if its not a full sentence then it doesn't get a full stop.
tcharding
reviewed
Jul 19, 2025
Comment on lines
+34
to
+35
| /// > 6. descriptors (boolean, optional, default=true) Create a native descriptor wallet. The wallet will use descriptors internally to handle address creation | ||
| /// > 6. descriptors (boolean, optional, default=true) Create a native descriptor wallet. The wallet will use descriptors internally to handle address creation. | ||
| /// > 6. descriptors (boolean, optional, default=true) Create a native descriptor wallet. The wallet will use descriptors internally to handle address creation. |
Member
There was a problem hiding this comment.
Duplicate line. But anyways lets not patch the Core docs (same comment as in another place during this review).
tcharding
reviewed
Jul 19, 2025
tcharding
left a comment
tcharding
left a comment
Member
There was a problem hiding this comment.
Just two fixes, everything else looks good. What tool did you use? Your editor's AI setup?
tcharding
added a commit
that referenced
this pull request
Jul 19, 2025
b4d2681 Add full stops to rustdocs in node (Jamil Lambert, PhD) Pull request description: Use AI to go through every file in node and add missing full stops to the rust docs. Together with #302, #303 and #304 Closes #296 ACKs for top commit: tcharding: ACK b4d2681 Tree-SHA512: 7153ac583469b1481ebcab64e70e2c86a9669fc450059c90e399aca6f55471c8d1cccef9970774b9713d634a9179d0363fe155938d5e9270416a46d7dcd6df36
jamillambert
force-pushed
the
0718-client-fullstops
branch
2 times, most recently
from
5472a76 to
59a163f
Compare
Collaborator
Author
Removed the change to section from Core docs. Removed the changes to comments, not sure why it did just this section and not everywhere. Also not sure why it duplicated that one line. NB. there were other errors it made, just that I found them before committing the changes. Still a lot quicker than trying to do this manually. I used copilot in vscode in agent mode with GPT-4.1. I pay for copilot through github. |
tcharding
previously approved these changes
Jul 22, 2025
Member
|
Needs rebase mate. |
Use AI to go through every file in client and add missing full stops to the rust docs.
jamillambert
force-pushed
the
0718-client-fullstops
branch
from
59a163f to
4a2d02e
Compare
Collaborator
Author
|
Rebased |
tcharding
approved these changes
Jul 22, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
4a2d02e75219a36883c5407643ff7d02f284d5d4 Add full stops to rustdocs in Client (Jamil Lambert, PhD)
Pull request description:
Use AI to go through every file in client and add missing full stops to the rust docs.
There is one typo it also fixed without asking that I noticed.
Part of the fix for issue #296
ACKs for top commit:
tcharding:
ACK 4a2d02e75219a36883c5407643ff7d02f284d5d4
Tree-SHA512: 5d7b71ad93ef2d86b5b7212fa9f157ca98f4ce02767b044e991a4a8f1e91393ecb054f1cbb323e873f4253e95862c0854a4e0fc32998571af56bccd7ffab0543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use AI to go through every file in client and add missing full stops to the rust docs.
There is one typo it also fixed without asking that I noticed.
Part of the fix for issue #296