Improve bitcoind multithreading#632
Merged
tcharding merged 1 commit intoJun 18, 2026
Merged
Conversation
I got timeouts and errors reading tmp files when running the tests with 16 threads. Use kill + wait cleanup on all retry/error paths. Fix base-client creation path so it no longer bails without cleanup and instead retries cleanly. Fix final wallet-load failure path to always terminate/reap before returning. Create consts for the retry and timeout values and increase them. Assisted-by: GitHub Copilot (GPT-5.3-Codex)
tcharding
approved these changes
Jun 18, 2026
Member
|
FTR this would have been better as a bunch of patches. |
Collaborator
Author
Sorry my bad. I should have spent more time tidying up after the LLM. Feels like that's half my job now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got timeouts and errors reading tmp files when running the tests with 16 threads. After this fix it runs fine.
Use kill + wait cleanup on all retry/error paths.
Fix base-client creation path so it no longer bails without cleanup and instead retries cleanly.
Fix final wallet-load failure path to always terminate/reap before returning.
Create consts for the retry and timeout values and increase them.
Assisted-by: GitHub Copilot