Fix all the issues with verify --tests#634
Merged
Merged
Conversation
A couple of tests had a single underscore before the word `modelled`. Change them to a double underscore.
loadtxoutset said it was untested but it is tested. Remove the label.
Some tests with models are missing the suffix. Add it.
A couple of test names were missing the underscore between words. Add the missing underscore.
Including testing v17 by checking that the RPC is successful only, and gate out the assertions on the returned data that is not in v17.
There are a set of RPCs that are deprecated in v17 and removed in v18. They are all untested, so mark them as so.
There was a combination of both. In types it is a single work, so keep it that way in client and verify too. Search and replace all instances of key_pool with keypool.
tcharding
approved these changes
Jun 18, 2026
Member
|
Nice one man. We should probably consider running verify with |
Collaborator
Author
Yeah, it's quite a quick check. I wonder if it can be added to the end of the integration_test CI since that needs to be run first to generate the output file. But only run it if the test passes, otherwise you will get a whole list of missing tests for the ones that weren't run. Opened #639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a bunch of issues with test names and labels in verify that cause the fixed
verifywith--teststo fail.Fix all of them, including the RPCs that are actually not tested by adding the label to the types table and also mentioning them in the new issue #633.