Follow-ups for Bitcoin Core v31.0 support#635
Merged
Conversation
The field access did not assert anything. Just check that the call deserializes into a Logging value, like the other tests in the file.
v31 getwalletinfo no longer returns paytxfee, so reusing the v30 error left an unused PayTxFee variant. Give v31 its own GetWalletInfoError. Reuses scanning and last processed block types from v30.
Model CoinbaseTransaction beyond primitive types so into_model does real conversions. This needs v31 specific GetBlockVerbose error types to carry the new coinbase_tx conversion error.
Drop the mempool_only and return_spending_tx arguments from the typed method to match corepc style. The test that needs return_spending_tx issues the RPC directly.
satsfy
force-pushed
the
followup-v31-fixes
branch
from
6520423 to
78a7762
Compare
tcharding
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are follow-ups to the v31.0 support work, addressing review comments left after it was merged.
CoinbaseTransactionnow uses concrete rust-bitcoin types instead of primitives. v31 gains new error types to carry thecoinbase_txconversion error.GetWalletInfoErrorbecause 31 no longer returnspaytxfee.GetWalletInfoScanningandLastProcessedBlocktypes it reuses are imported from v30 directly rather than through the v31 re-export.loggingtest removed.get_tx_spending_prevoutby dropsmempool_onlyandreturn_spending_tx.