use hex-conservative 1.0 everywhere for decoding #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drafting. Might as well just wait for the real 1.0. |
apoelstra
force-pushed
the
push-ppmrkrkvqkzo
branch
3 times, most recently
from
fb0adc3 to
bea8cde
Compare
|
Published :) will update this tonight or tomorrow morning. |
apoelstra
force-pushed
the
push-ppmrkrkvqkzo
branch
from
bea8cde to
78e8f01
Compare
tcharding
approved these changes
Jul 15, 2025
|
PR title and git log are both stale - they mention 'rc'. |
tcharding
reviewed
Jul 15, 2025
| fn extend_vec_from_hex(hex: &str, out: &mut Vec<u8>) { | ||
| let mut b = 0; | ||
| for (idx, c) in hex.as_bytes().iter().enumerate() { | ||
| b <<= 4; | ||
| match *c { | ||
| b'A'..=b'F' => b |= c - b'A' + 10, | ||
| b'a'..=b'f' => b |= c - b'a' + 10, | ||
| b'0'..=b'9' => b |= c - b'0', | ||
| _ => panic!("Bad hex"), | ||
| } | ||
| if (idx & 1) == 1 { | ||
| out.push(b); | ||
| b = 0; | ||
| } | ||
| } | ||
| } | ||
| use miniscript::hex; |
tcharding
reviewed
Jul 15, 2025
Comment on lines
-74
to
+73
| let depo_tx: Transaction = deserialize(&Vec::<u8>::from_hex(hex_tx).unwrap()).unwrap(); | ||
| let depo_tx: Transaction = deserialize_hex(hex_tx).unwrap(); |
There was a problem hiding this comment.
This is kind of an unrelated change, bad Andrew no biscuit.
There was a problem hiding this comment.
How is it unrelated? We used to have a hex library that has from_hex and now we don't.
tcharding
reviewed
Jul 15, 2025
Comment on lines
-1658
to
+1657
| Vec::<u8>::from_hex("76a91479091972186c449eb1ded22b78e40d009bdf008988ac").unwrap()[..] | ||
| hex::decode_to_vec("76a91479091972186c449eb1ded22b78e40d009bdf008988ac").unwrap()[..] |
There was a problem hiding this comment.
Out of interest did you find yourself cursing the f***ing hex-conservative devs or were you happy enough during the upgrade?
There was a problem hiding this comment.
I was happy enough, but the lack of encoding support is idiotic.
apoelstra
changed the title
It turns out we only ever use do decoding of fixed test vectors. It would be nice to have a hex! macro for this. Eventually. In some cases we were able to use inherent methods on bitcoin types -- for example ScriptBuf::from_hex or deserialize_hex.
apoelstra
force-pushed
the
push-ppmrkrkvqkzo
branch
from
78e8f01 to
a1fa898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we only ever use do decoding of fixed test vectors. It would be nice to have a hex! macro for this. Eventually.
In some cases we were able to use inherent methods on bitcoin types -- for example ScriptBuf::from_hex or deserialize_hex.