fix(keymap): backport use of correct derivation_path for keys with origin
#867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…origin - Fixes the implementation of `GetKey` for `KeyRequest::Bip32` when there's `Xpriv` has an origin, and it matches with the given `KeyRequest::Bip32` derivation_path. It should strip the matching part, to correctly derive the key at the correct child number. - Updates the existing test to the correct and expected behavior.
|
Do you want review mate? Why's it draft? |
Yeah, I was just waiting for CI, it should be ready to go. |
tcharding
approved these changes
Oct 27, 2025
|
I'll move this one back to draft while I fix the issue mentioned at the summit, and backport all the fixes at once. |
oleonardolima
force-pushed
the
backport-863-to-12.x
branch
from
ff9419c to
51df447
Compare
- fixes the implementation of `GetKey` for `Xprv` with `KeyRequest::Bip32` and a key_origin information. - adds a new test for a scenario where no wildcard is used, and an specific derivation index is used.
oleonardolima
force-pushed
the
backport-863-to-12.x
branch
from
51df447 to
d6a94e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #863
GetKeyforKeyRequest::Bip32when there'sXprivhas an origin, and it matches with the givenKeyRequest::Bip32derivation_path. It should strip the matching part, to correctly derive the key at the correct child number.