Add grss implementation to errors chapter
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of the chapter, provide a running code example that applies the nicer error reporting to the `grrs` tool.
|
I think the chapters following 1.3 should continue to improve the central See also #222. |
stomar
force-pushed
the
add-grrs-impl-to-errors
branch
from
0fc865b
to
2f8fec9
Compare
pksunkara
approved these changes
Nov 8, 2023
|
I do not know how PRs are usually merged in this repository (squash, rebase, etc.); in this case I would prefer both commits were kept separately, i. e. no "squash and merge". IMO the second commit does not improve the text, as explained above; I also do not see any value in using an (empty) phrase merely for "consistency" with only 2 other uses. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the chapter, provide a running code example that applies the nicer error reporting to the
grrstool.