Allow setting window size in spawned process. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use-case for this is for testing a shell that uses the
rustylinecrate for line-editing.For long inputs (greater than the terminal width),
rustylineinserts newlines into its output, which breaks tests usingrexpectto match expected strings.This PR would allow users to for example, set the terminal size to 200 columns wide, avoiding the aforementioned problem.
The feature is available in
pexpect.Coincidentally, this PR addresses the newly opened #119.
Draft Status
The PR is in draft because I am not sure what the best way to go about passing the
Optionsis.Currently it already feels weird to me propagating the
reader::Optionsfromspawn_with_optionsdown the various containers to theNBReader.