Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Do not quote default values #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not quote default values #105

wants to merge 2 commits into from

Conversation

cschmatzler
Copy link

Single-quoting the value makes it impossible to use functions.

Instead, the quoting should happen in the parameter to default().

This should also close #99.

Christoph Schmatzler added 2 commits January 5, 2021 23:41
Single-quoting the value makes it impossible to use functions. Instead, the quoting should happen in the parameter to default()
@cschmatzler
Copy link
Author

Updated the PR to do the same for SQLite and MySQL, should now also close #90.

@cschmatzler cschmatzler changed the title Do not quote default values for Pg backend Do not quote default values Jan 5, 2021
@spacekookie
Copy link
Collaborator

Hey, thanks for this PR.

Could you try rebasing your branch? I merged a bunch of PRs that have been open for way too long 🙈

Once that's taken care of I'll merge this without there being any tests for this because I'm planning on rebuilding the entire way that barrel is tested anyway

@Th3Whit3Wolf Th3Whit3Wolf mentioned this pull request Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default for Date and different Date Types
2 participants