Implement Ord and PartialOrd for ShortFileName. #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-vri-es
force-pushed
the
shortname-ord
branch
from
a56307c to
d9204b3
Compare
thejpster
approved these changes
Oct 31, 2025
|
Looks good to me. I appreciate the test cases. |
Merged
via the queue into
rust-embedded-community:develop
with commit Oct 31, 2025
c629f38
7 checks passed
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be useful to directly compare short filenames lexicographically.
Should be fine to derive because all characters lower than a space are illegal, and spaces indicate the end of a string. No legal character compares lower than a space, so shorter strings are always sorted before longer string.