Swap everything from SVG to PNG #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomInsano
requested review from
berkus,
rahul-thakoor and
a team
as code owners
Closed
therealprof
requested changes
Sep 29, 2018
There was a problem hiding this comment.
I measured several times now and with cold caches the loading times are the exact same ~1.3s here, no matter whether it's svg or png. However the PNGs are quite a substantial increase in transferred size on this already very bandwidth unfriendly page so I'm very much opposed to worsening it more.
|
The times are now inconsistent on my end (ranging from 1 to 20 seconds) regardless of content type or browser, so I'm in favour of closing this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance gains outlined here.
Change made was applying this regular expression:
From: "(img.shields.io.*)svg"
To: "\1png"