Refactor VectActive to Vector and pass it to DefaultHandler.
#437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
reitermarkus
force-pushed
the
active-vector
branch
3 times, most recently
from
ef6fb9b to
fd04623
Compare
reitermarkus
force-pushed
the
active-vector
branch
5 times, most recently
from
0b207d0 to
75c8227
Compare
reitermarkus
force-pushed
the
active-vector
branch
from
75c8227 to
53c40eb
Compare
|
@thalesfragoso, ping. |
|
Sorry we dropped this one. It looks OK to me, but it's a breaking change. @rust-embedded/arm how do we feel about breaking changes in cortex-m / cortex-m-rt 0.8? |
| } | ||
|
|
||
| impl TryFrom<i8> for Exception { | ||
| type Error = i8; |
There was a problem hiding this comment.
Any reason for returning the argument back on error?
I don't have a problem with breaking changes in 0.8 per se, but breaking both c-m and c-m-rt at the same time in an inter-dependent way will make upgrading even harder than it already is, so the change would have to be really well motivated and I don't really understand the motivation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Vector::map_interruptfunction to allow mapping theVector::Interruptvariant to e.g. a HAL's interrupt type.SCB::vect_pendingfunction for getting the pending vector, if any.