Skip to content

[proposal] release 0.3.0 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ryankurte
Copy link
Contributor

@ryankurte ryankurte commented Jan 6, 2020

Swaps digital trait default to digital::v2 (breaking change), as the next step in the planned digital::v1 deprecation, as an alternative to rust-embedded/wg#393.

This approach is aligned with all other HAL traits (where Infallible is returned for infallible implementations), minimises complexity (by not introducing multiple options that must be effectively communicated to all users, or the opportunity for incompatibility due to use of the incorrect trait) with the end goal of removing the version numbers and having a single set of fallible digital::* traits.

I had hoped to port the compatibility shims back to the v0.2 series, however, this seems impossible to do without cyclic dependencies.

Dependencies

Impact

  • HAL consumers using digital::* traits directly will need to update to fallible types
  • HAL consumers using digital::v1::* or digital::v2::* will observe no change

Next steps

  • HAL v0.4.x series should remove digital::{v1, v1_compat, v2_compat} to complete the migration

@rust-highfive
Copy link

r? @ithinuel

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Jan 6, 2020
@ryankurte ryankurte changed the title Release 0.3.0 [proposal] release 0.3.0 Jan 6, 2020
@ryankurte ryankurte added needs-decision S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 6, 2020
@ryankurte
Copy link
Contributor Author

Closing as replaced by #192

@ryankurte ryankurte closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision S-waiting-on-review Review is incomplete S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants