Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps digital trait default to
digital::v2
(breaking change), as the next step in the planneddigital::v1
deprecation, as an alternative to rust-embedded/wg#393.This approach is aligned with all other HAL traits (where
Infallible
is returned for infallible implementations), minimises complexity (by not introducing multiple options that must be effectively communicated to all users, or the opportunity for incompatibility due to use of the incorrect trait) with the end goal of removing the version numbers and having a single set of fallibledigital::*
traits.I had hoped to port the compatibility shims back to the v0.2 series, however, this seems impossible to do without cyclic dependencies.
Dependencies
Impact
digital::*
traits directly will need to update to fallible typesdigital::v1::*
ordigital::v2::*
will observe no changeNext steps
digital::{v1, v1_compat, v2_compat}
to complete the migration