Fix UB in pool module when using ArcBlock<T> and BoxBlock<T>
#612
+62
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgued
previously approved these changes
Sep 22, 2025
zeenix
reviewed
Oct 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
Fix UB in `pool` module when using `ArcBlock<T>` and `BoxBlock<T>`
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…n in ArcPool and BoxPool
sgued
force-pushed
the
pool-node-ref-fix
branch
from
16890c9 to
e571afe
Compare
|
There was a rebase conflict that caused the CI to fail. Thanks merge queues for avoiding a broken main. @zeenix can you please re-review ? Since I forced push it doesn't want me to merge alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes UB when using the
ArcBlock<T>andBoxBlock<T>types together with theStacktype, as it occurs in theArcPoolImplandBoxPoolImpltypes. The underlying cause for the UB was a wrongly initializedUnionNode, as was discussed in #605 . This also required that the functions of theNodetrait areunsafe, but this should not be a breaking API change as that trait is never exported from thepoolmodule