-
Notifications
You must be signed in to change notification settings - Fork 186
Add mtopi CSR #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add mtopi CSR #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few changes: add the field check in the new macro to check the field bit range and use hex representation in a test.
Co-authored-by: Román Cárdenas Rodríguez <[email protected]>
|
I feel like this CI failing again, isn't the fault of the code changes made in this PR, the spellings were definitely not changed by me, I can & will fix this, but it's quiet late in my timezone... and as for the lints, same condition there, I'll fix them :) |
|
Don't worry about CI now, I will try to have it working ASAP (Nightly clippy triggers new errors from time to time). The checks that fail are not blockers for merging. Please, address the comment about the tests and it is good to go. |
Fine! I have updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Minor changes
Co-authored-by: Román Cárdenas Rodríguez <[email protected]>
Co-authored-by: Román Cárdenas Rodríguez <[email protected]>
Co-authored-by: Román Cárdenas Rodríguez <[email protected]>
|
Thanks! @romancardenas for giving the review + commits, I have applied them, if there's any other change I'll happily make them :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR reintroduces the mtopi CSR addition from my previous PRs (#347 and #359),
but from a clean branch as suggested by the reviewers.
The diff is identical to the intended changes; commit history has been cleaned up.