Set RUSTDOCFLAGS to avoid issues with linkage for doctests. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per issue rust-fuzz#142, `cargo afl test` and other commands that would run doctests would encounter issues with linkage. This commit changes `cargo afl` to set RUSTDOCFLAGS so rustdoc will be able to find the required libs. Further options are passed to ensure doctests are built and run in as similar a fashion to other code. This avoids other gotchas like cfg fuzzing being set for normal builds, but not for doctests.
|
#141 causes some pain while testing with this, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #142,
cargo afl testand other commands that would rundoctests would encounter issues with linkage. This commit changes
cargo aflto set RUSTDOCFLAGS so rustdoc will be able to find the requiredlibs. Further options are passed to ensure doctests are built and run in
as similar a fashion to other code. This avoids other gotchas like cfg
fuzzing being set for normal builds, but not for doctests.