-
Notifications
You must be signed in to change notification settings - Fork 301
Add "The incoming Summer of Clippy" post #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quick! I don't have time to review the blog post today. But should this go into content/inside-rust
instead? I feel like this is more of an inside-rust blog post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, this serves as a half announcement to overall the Rust community (they won't be getting new features for a while) and also to the contributors, as they now have distinct goals to aim to. (That tracking issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will be really noticable to non-contributors, if there aren't any new lints for 2 releases. And the ones that do notice, will probably find this blog post, even when published in internal-rust
The internal-rust blog is for the contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small fixes. Good job on the blog post!
upping the standard for lints all around the project we can allow users to | ||
expect even more from the already great linter. | ||
|
||
If you have a lint which you want to be implemented, you can still open and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a lint which you want to be implemented, you can still open and | |
If you have a lint which you want to be implemented, you can still open an |
Typo
|
||
If you have a lint which you want to be implemented, you can still open and | ||
issue for it, but no one will implement it (also, lint-adding pull requests | ||
opened after the starting date will be blocked for the duration of the period) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing sentence period.
|
||
Note that pull requests opened before the starting date can still be reviewed | ||
and merged, but unless they are already in a very advanced state they will not | ||
be priorized over bugfixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be priorized over bugfixes. | |
be prioritized over bugfixes. |
## Can I help? | ||
|
||
As always, any help on the project is very appreciated. Apart from opening bug | ||
reports, you can follow our [contributing guidelines] and check [our suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not: the "our" should be let in or out of the link consistently.
for current and future changes in the compiler as a whole. | ||
|
||
As a team we’ll focus on making contributing the best it can be, we’ll try to | ||
bisect all the issues possible and mark the issues that could be great as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you mean "dissect" here? (because bisection would probably give us the point of introduction of the lint)
We are currently working on a feature freeze for the Clippy project. This | ||
period would be 12 weeks long, starting on the introduction of 1.89 to beta | ||
on the 26 of June, and ending on the 18th of September. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, after reading the whole blog post I understand that from end of June until mid-September Clippy won't accept new feature requests but only fixes to existing lints - is that correct?
I think a TL;DR; of this kind could help, since the title is nice 😎 but doesn't explicit what is really being communicated.
How about this slightly reworded version:
We are currently working on a feature freeze for the Clippy project. This | |
period would be 12 weeks long, starting on the introduction of 1.89 to beta | |
on the 26 of June, and ending on the 18th of September. | |
The Clippy project will be on feature-freeze for 12 weeks, starting from Rust 1.89.0 beta (June 26th 2025) to Rust 1.91.0 beta (September 18th 2025). During this time no new features will be accepted, only bug fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this might be clearer to read, maybe not an explicit TL;DR because it's less than 500 words.
This is the initial draft for "The incoming Summer of Clippy", talked about in our All Hands.
For reviewing ease, here's everything I wanted to talk about:
We are currently blocked on not having a tracking issue for the good first issues (and we do not have a lot of issues marked with the label in the repo). But I think that this is still ready for an initial review from the team.
Related to https://hackmd.io/nubu1rGOTliW1MZPilplaA
@rust-lang/clippy
Rendered