Fix year delimiters in releases page #1615
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach to detect if a release is the last one in a year was incorrect. It checked if the following post was in the next year. However, the following post doesn't have to be a release, so the check could fail. The result was missing year delimiters "Releases in YYYY". A mutable variable makes it easier to track the actual year of the last rendered release post.
Manishearth
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach to detect if a release is the last one in a year was incorrect. It checked if the following post was in the next year. However, the following post doesn't have to be a release, so the check could fail.
The result was missing year delimiters "Releases in YYYY".
A mutable variable makes it easier to track the actual year of the last rendered release post.