-
Notifications
You must be signed in to change notification settings - Fork 306
Change branch name from master to main #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Connects to rust-lang#1687.
Maybe @rust-lang/infra has the permissions? (or knows who does...) |
Yes, this pretty much has to be done by an infra admin. A PR also has to be sent to the team repo to update branch protections. |
This PR looks good to me.
Does the sequence looks right? |
Maybe it's possible to protect both master and main in the pattern? Then the team repo PR can be merged first, so there is no "downtime" for the branch protection. |
I don't think that's needed, but it would also work. |
I also don't think it's needed to protect both main and master since I will perform the steps quickly 👍 |
Note that promote-release might require an update for this (https://github.com/rust-lang/promote-release/blob/ee6866331f1d61fc9faa5df00bc0305eb7a2ad65/src/main.rs#L37). |
oh, ok, than: we should wait for rust-lang/promote-release#95 to be deployed first 👍 |
(My PR doesn't fix this, it only removes master references for r-l/r, not the blog.) |
oh, I see, so we need to open another PR to fix it 👍 |
Connects to #1687.
This will need someone with the right permissions to actually do the branch rename :)