Skip to content

Fix i256::MAX #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Fix i256::MAX #912

merged 1 commit into from
May 13, 2025

Conversation

TDecking
Copy link
Contributor

@TDecking TDecking commented May 8, 2025

No description provided.

@tgross35
Copy link
Contributor

Good catch, thanks. Would you mind updating the version at

const MAX: Self = Self {
lo: u128::MAX,
hi: u128::MAX << 1,
};
as well? (I'll hopefully be deduplicating these to share the libm version in the near future since it's a bit faster).

I should figure out a way to sanity check our constants somehow (maybe also against rug like libm-test/tests/u256.rs).

@TDecking
Copy link
Contributor Author

@tgross35 Done.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 enabled auto-merge (rebase) May 12, 2025 14:06
@tgross35 tgross35 merged commit f2918cd into rust-lang:master May 13, 2025
35 checks passed
@TDecking TDecking deleted the i256-max branch May 13, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants