Add ppc64le support

[Jenkins-J]

Add ppc64le support to Rust bullseye and bookworm images. The Debian buster container image does not currently support the ppc64le architecture. This builds on the work in pull request #101 and addresses issue #54.

[mkumatag]

@sfackler can you please review this PR?

[clnperez]

@Jenkins-J looks like this needs a rebase

[Jenkins-J]

@sfackler I've rebased the changes for this pull request. Is there anything else I need to do to have this reviewed and merged?

[Jenkins-J]

@sfackler there are projects such as https://github.com/IBM/text-generation-inference that aim to support the ppc64le architecture and would benefit from ppc64le support in the official Rust Docker image. Are there any other blockers to adding ppc64le support?

[Jenkins-J]

@sfackler @Muscraft I have rebased the changes on the master branch again. Is there anything else holding this PR back from being merged?

[Muscraft]

These lines will also need to be changed:

docker-rust/x.py

Lines 189 to 192 in 743e6f4

	library += single_library(
	tags,
	map(lambda a: a.bashbrew, debian_arches),
	os.path.join(rust_version, variant))

        arches = debian_arches
        if variant != "buster":
            arches += debian_non_buster_arches

        library += single_library(
                tags,
                map(lambda a: a.bashbrew, arches),
                os.path.join(rust_version, variant)) 

---

docker-rust/x.py

Lines 203 to 206 in 743e6f4

	library += single_library(
	tags,
	map(lambda a: a.bashbrew, debian_arches),
	os.path.join(rust_version, variant, "slim"))

        library += single_library(
                tags,
                map(lambda a: a.bashbrew, arches),
                os.path.join(rust_version, variant, "slim"))

[Muscraft]

The reason this has been hard to decide on is there is currently no policy on what architectures we support similar to rustc's Platform Support.

After talking with @sfackler, we should support architecture that meets the following criteria:

• Targets that are either Tier 1 with Host Tools or Tier 2 with Host Tools
• Supported by docker's official images
• Supported by their respective distro

One caveat is that I don't have any hardware to test images for architectures other than amd64 and arm64v8 so other architectures are best effort.

[Muscraft]

These two are meant to be different correct?

[Jenkins-J]

Yes, that is correct. The value for bashbrew is ppc64le while the dpkg architecture value needs to be ppc64el.

[clnperez]

One caveat is that I don't have any hardware to test images for architectures other than amd64 and arm64v8 so other architectures are best effort.

@Muscraft - We have an agreement with OSU that you can, as a maintainer of an open source project, get an OpenStack-managed Power VM there pretty easily: https://osuosl.org/services/powerdev/request_hosting. They'll spin you up a VM, add your SSH key to it, and it's yours. If you're interested let me know. But we're fine with the best effort approach and are happy to be pinged to fix things as well.

Thanks for the review!

[Muscraft]

When I suggested this line, I forgot it wasn't copying debian_arches, only creating a reference and then mutating it (I deeply miss Rust when I am not using it). It caused ppc64le to be added twice. To fix this, we just need to copy it.

Suggested change

	arches = debian_arches
	arches = debian_arches[:]

[Jenkins-J]

Thank you, it is fixed now.

[Muscraft]

docker-library/official-images#16055